Skip to content

add benchmarks for single column group-values traits#23070

Open
Rich-T-kid wants to merge 1 commit into
apache:mainfrom
Rich-T-kid:rich-T-kid/GroupValuesBenchmarks
Open

add benchmarks for single column group-values traits#23070
Rich-T-kid wants to merge 1 commit into
apache:mainfrom
Rich-T-kid:rich-T-kid/GroupValuesBenchmarks

Conversation

@Rich-T-kid

@Rich-T-kid Rich-T-kid commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

this PR works towards #9195
see comment #9195 (comment)

Rationale for this change

there is a lack of benchmarks for the singlar GroupValue traits. #22004 was added a little while ago and when looking for optimizations for #9195 i noticed there wasn't a way to measure improvement. I went ahead and included benchmarks for the other single column types besides GroupsValueByteView.

What changes are included in this PR?

benchmarks for all single-column GroupValues traits.

Are these changes tested?

N/a

Are there any user-facing changes?

no

@github-actions github-actions Bot added the physical-plan Changes to the physical-plan crate label Jun 22, 2026
@Rich-T-kid

Rich-T-kid commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

@alamb you created #9195 so I think you'd have interest in this PR (and eventually the follow up)

@Rich-T-kid

Rich-T-kid commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

CI is breaking for unrelated reasons

Run rustup toolchain install stable
info: syncing channel updates for stable-x86_64-unknown-linux-gnu
error: could not download file from 'https://static.rust-lang.org/dist/channel-rust-stable.toml.sha256' to '/home/runner/.rustup/tmp/dxx48lj3q7pqsnn4_file': error downloading file: error sending request for url (https://static.rust-lang.org/dist/channel-rust-stable.toml.sha256): client error (Connect): tcp connect error: Connection timed out (os error 110)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

physical-plan Changes to the physical-plan crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Rich-T-kid